Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

feat: add code for alizer npm package #27

Merged
merged 6 commits into from
Jul 2, 2021

Conversation

lstocchi
Copy link
Collaborator

@lstocchi lstocchi commented Jul 2, 2021

it resolves #20

cc @evidolob

lstocchi added 2 commits July 2, 2021 10:09
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from jeffmaury July 2, 2021 08:25
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and

  • nice to have a few unit tests
  • language.yml file duplicated, at least open an issue to share it between implementations
  • add or edit workflows

js/src/recognizer.ts Outdated Show resolved Hide resolved
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi
Copy link
Collaborator Author

lstocchi commented Jul 2, 2021

See comments and

  • nice to have a few unit tests
  • language.yml file duplicated, at least open an issue to share it between implementations
  • add or edit workflows

I just copied everything as it is here so yevhen can start working with it. I'll open new issues for the second/third point

@jeffmaury
Copy link
Member

See comments and

  • nice to have a few unit tests
  • language.yml file duplicated, at least open an issue to share it between implementations
  • add or edit workflows

I just copied everything as it is here so yevhen can start working with it. I'll open new issues for the second/third point

Point 3 is required for us to validate changes

lstocchi added 2 commits July 2, 2021 13:45
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@@ -9,7 +9,7 @@ on:
branches: [ main ]

jobs:
build:
build-java:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the name of the workflow needs to be renamed as well

Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested a review from jeffmaury July 2, 2021 12:12
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit 565736c into redhat-developer:main Jul 2, 2021
@lstocchi lstocchi deleted the addjs branch July 2, 2021 12:44
@lstocchi
Copy link
Collaborator Author

lstocchi commented Jul 2, 2021

All yours @evidolob

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Javascript implementation
3 participants