-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments and
- nice to have a few unit tests
- language.yml file duplicated, at least open an issue to share it between implementations
- add or edit workflows
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
I just copied everything as it is here so yevhen can start working with it. I'll open new issues for the second/third point |
Point 3 is required for us to validate changes |
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
@@ -9,7 +9,7 @@ on: | |||
branches: [ main ] | |||
|
|||
jobs: | |||
build: | |||
build-java: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the name of the workflow needs to be renamed as well
Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All yours @evidolob |
it resolves #20
cc @evidolob